bank-of-anthos icon indicating copy to clipboard operation
bank-of-anthos copied to clipboard

Pylint - switch to Google style guide

Open askmeegs opened this issue 3 years ago • 6 comments

Current we have a pylint file - https://github.com/GoogleCloudPlatform/bank-of-anthos/blob/master/.pylintrc - that ignores certain pylint errors in the Python service source code.

Let's try to remove most of these ignores to get the most out of linting, using Google's python style guide as source material for what messages might be okay to ignore.

askmeegs avatar Mar 08 '21 14:03 askmeegs

This is still planned in the long term.

bourgeoisor avatar Mar 01 '22 15:03 bourgeoisor

Still want to do this. @glasnt also suggested considering black as an alternative to pylint.

bourgeoisor avatar Sep 07 '22 03:09 bourgeoisor

python-docs-samples uses flake8 (to conform to the styleguide) and black is optional (docs). The flake8 config in noxfile.py should be useful here.

glasnt avatar Sep 08 '22 04:09 glasnt

pyink is a fork of black under the Google org and may be an alternate to black https://github.com/google/pyink

parthea avatar Feb 02 '23 17:02 parthea

isort tool can also be used to sort imports https://github.com/PyCQA/isort

parthea avatar Feb 02 '23 17:02 parthea

The work on this item is postponed to Q4'24

minherz avatar Jul 27 '23 16:07 minherz