appengine-plugins icon indicating copy to clipboard operation
appengine-plugins copied to clipboard

Published 20 hours ago • verified publisher icon GoogleCloudPlatform

WaitProcessOutputListener needs to be provided by the AppEngineDevServer implementation

Open patflynn opened this issue 8 years ago • 5 comments

related to #330

currently CloudSdk#637 hardcodes the value that triggers server startup complete event.

patflynn avatar Feb 15 '17 22:02 patflynn

@loosebazooka we need this fix in for the IDE integrations to work with Ludo's PR.

patflynn avatar Feb 16 '17 13:02 patflynn

Is this a stdout vs stderr thing? The string we are looking for is correct.

loosebazooka avatar Mar 27 '17 20:03 loosebazooka

@loosebazooka Oh, so devappserver1 and 2 both use the same log message when starting up?

".*(Dev App Server is now running|INFO:oejs\\.Server:main: Started).*",

chanseokoh avatar Mar 27 '17 20:03 chanseokoh

dev appserver 1 is the first part and dev appserver 2 is the second.

loosebazooka avatar Mar 27 '17 21:03 loosebazooka

Got it. I thought this issue is talking about refactoring the code so that the expected log messages are provided by server implementations rather than hard-coded in CloudSdk, but we may be okay as long as it's working.

chanseokoh avatar Mar 27 '17 21:03 chanseokoh