appengine-endpoints-helloendpoints-java-maven icon indicating copy to clipboard operation
appengine-endpoints-helloendpoints-java-maven copied to clipboard

moving the app.id and app.version configuration to only pom.xml

Open arsenicraghav opened this issue 9 years ago • 3 comments

As we are using maven, it would be better if we have the app.id and app.version configuration in pom.xml just in once place and then use these properties in appengine-web.xml. Also need to add the app.id and app.version to the configuration of appengine-maven-plugin as it is required when deploying and if absent throws an error and hence works like a bug fix.

arsenicraghav avatar Aug 10 '16 12:08 arsenicraghav

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Aug 10 '16 12:08 googlebot

I have signed it!

Thanks

On Wed, Aug 10, 2016 at 6:12 PM, googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
  • If you signed the CLA as a corporation, please let us know the company's name.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/appengine-endpoints-helloendpoints-java-maven/pull/11#issuecomment-238854504, or mute the thread https://github.com/notifications/unsubscribe-auth/AJCWnuNTcKM7NR6KBKhKuCkAsLQIaf9uks5qeccbgaJpZM4JhGeY .

Raghvendra Kumar

Sr. Analyst | Google Practice | Cloud First Applications

D: +91 22-43870645 M : +91 9620693638

arsenicraghav avatar Aug 10 '16 12:08 arsenicraghav

CLAs look good, thanks!

googlebot avatar Aug 10 '16 12:08 googlebot