GoogleCloudPlatform
fix(deps): update module github.com/googlecloudplatform/cloud-foundation-toolkit/infra/blueprint-test to v0.7.0
This PR contains the following updates:
| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test | require | minor | v0.4.1 -> v0.7.0 |
v0.8.0 |
Release Notes
GoogleCloudPlatform/cloud-foundation-toolkit (github.com/GoogleCloudPlatform/cloud-foundation-toolkit/infra/blueprint-test)
v0.5.2: CLI Release v0.5.2
v0.5.1: CLI Release v0.5.1
v0.5.0: CLI Release v0.5.0
Configuration
📅 Schedule: Branch creation - "every 3 months on the first day of the month" in timezone America/New_York, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR has been generated by Mend Renovate. View repository job log here.
The error I'm seeing in the failing anthos-samples-int-trigger check (build logs here):
...
/builder/home/go/pkg/mod/k8s.io/[email protected]/pkg/internal/third_party/go-json-experiment/json/arshal_funcs.go:87:1: too many errors
note: module requires Go 1.19
# github.com/zclconf/go-cty/cty/set
/builder/home/go/pkg/mod/github.com/zclconf/[email protected]/cty/set/iterator.go:3:17: syntax error: unexpected any, expecting ]
...
/builder/home/go/pkg/mod/github.com/zclconf/[email protected]/cty/set/ops.go:117:12: too many errors
note: module requires Go 1.18
It sounds like this dependency bump requires Go 1.19.
I believe the Golang version being used by these integration tests is whatever Golang version found in this gcr.io/cloud-foundation-cicd/cft/developer-tools image.
The latest gcr.io/cloud-foundation-cicd/cft/developer-tools image (as of today) uses Golang 1.20:
➜ docker pull gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 # This takes a few minutes because the image is +1GB.
...
➜ docker run --name mycontainer -d -i -t gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 /bin/sh
cd4d145167dd93d10879ae7a81ed1ea1a580eead03d0ae2b44702d640503afa6
➜ docker exec -it mycontainer sh -c "go version"
go version go1.20.7 linux/amd64
➜ docker kill mycontainer
I found the latest image here.
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️ Warning: custom changes will be lost.
![forking-renovate[bot] avatar](https://avatars.githubusercontent.com/in/7402?v=4 "Published by a pub.dev verified publisher"){kind=small}
We're encountering a different error now (see build logs here):
Error: Unsupported Terraform Core version
on ../../../anthos-bm-gcp-terraform/versions.tf line 18, in terraform:
18: required_version = ">= v0.15.1, < 1.4" # this line should not change during a release
Module module.anthos_bm_gcp (from ../../../anthos-bm-gcp-terraform) does not
support Terraform version 1.5.5. To proceed, either choose another supported
Terraform version or update this version constraint. Version constraints are
normally set for good reason, so updating the constraint may lead to other
errors or unexpected behavior.
Namely, /anthos-bm-gcp-terraform does not allow Terraform 1.4 or lower.
I just checked the Terraform version of the gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 image. It's using Terraform v1.5.5.
docker pull
docker run --name mycontainer -d -i -t gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4 /bin/sh
docker exec -it mycontainer sh -c "terraform version"
Terraform v1.5.5
Next step should be:
a. see if we can update all Terraform version constraints to use Terraform 1.5.5 (or above) and continue using gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4
b. see if we can use a version of gcr.io/cloud-foundation-cicd/cft/developer-tools (i.e., downgrade 1.14.4) that contains both Golang 1.19 or higher and Terraform 1.3 or lower.
"Next steps" suggested in my previous comment:
a. see if we can update all Terraform version constraints to use Terraform 1.5.5 (or above) and continue using gcr.io/cloud-foundation-cicd/cft/developer-tools:1.14.4, or
b. see if we can use a version of gcr.io/cloud-foundation-cicd/cft/developer-tools (i.e., downgrade 1.14.4) that contains both Golang 1.19 or higher and Terraform 1.3 or lower.
We should try a.
We cannot move forward with b. See Google-internal chat thread here. There is no gcr.io/cloud-foundation-cicd/cft/developer-tools image that contains both:
- Golang 1.19 or higher and
- Terraform 1.3 or lower.
Terraform constraint bumped.
This is the error now:
Error: No value for required variable
on variables.tf line 17:
17: variable "editor_project_id" {
Error: No value for required variable
on variables.tf line 21:
21: variable "editor_sa_key_file_path" {
It's complaining about these variables that are not set with any values: https://github.com/GoogleCloudPlatform/anthos-samples/blob/main/test/fixtures/abm_gce_defaults_on_editor_project/variables.tf#L17-L23
I assume they should be set here: https://github.com/GoogleCloudPlatform/anthos-samples/blob/main/test/setup/outputs.tf#L19-L34
This is the PR that added those tests: https://github.com/GoogleCloudPlatform/anthos-samples/pull/39
@Shabirmean just reading the last comment, any thoughts? I'm not sure how those tests work, and why those outputs are not working as intended anymore.