fix: explicitly set CICD runner in E2E tests

[eliasecchig]

Summary

• Add explicit --cicd-runner google_cloud_build flag to E2E test create command
• Ensures E2E tests continue to test CI/CD pipelines after CLI default changed to "skip"

Problem

PR #647 changed the default CI/CD runner to "skip" mode for local development simplicity. However, E2E deployment tests rely on having CI/CD infrastructure to test the full deployment pipeline.

Solution

Explicitly pass --cicd-runner google_cloud_build when the test config doesn't already specify a CI/CD runner, ensuring tests create projects with proper CI/CD setup.

[gemini-code-assist[bot]]

Summary of Changes

Hello @eliasecchig, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where E2E deployment tests would fail to properly validate CI/CD pipelines due to a recent change in the CLI's default CI/CD runner. By explicitly configuring the google_cloud_build runner within the test setup, it ensures that the necessary CI/CD infrastructure is provisioned, thereby restoring the integrity and coverage of these critical end-to-end tests.

Highlights

• Explicit CI/CD Runner: The pull request explicitly sets the CI/CD runner to google_cloud_build for E2E tests during project creation.
• Addressing CLI Default Change: This change is necessary because the CLI's default CI/CD runner was recently changed to 'skip', which would prevent E2E deployment tests from properly testing CI/CD pipelines.
• Ensuring Test Coverage: By adding this flag, the E2E tests will continue to create projects with the required CI/CD infrastructure, ensuring full deployment pipeline testing.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.