agent-starter-pack icon indicating copy to clipboard operation
agent-starter-pack copied to clipboard

fix: complete Windows gcloud compatibility for all CLI commands

Open eliasecchig opened this issue 1 month ago • 2 comments

Summary

Completes the Windows compatibility work from #646 and centralizes gcloud command handling:

  • Create command.py utility with get_gcloud_cmd() and run_gcloud_command()
  • Update run_command() in cicd.py to auto-handle gcloud commands (fixes setup-cicd)
  • Migrate all direct subprocess gcloud calls to use centralized helper
  • Remove duplicated Windows compatibility logic across files

Changes

File Change
command.py New module with cached gcloud path resolution + Windows-safe wrapper
cicd.py run_command() auto-detects gcloud and handles Windows
gcp.py Uses run_gcloud_command, re-exports for backwards compat
create.py Uses run_gcloud_command
register_gemini_enterprise.py Uses run_gcloud_command

This ensures both create and setup-cicd commands work on Windows, with no code duplication.

eliasecchig avatar Dec 14 '25 23:12 eliasecchig

Summary of Changes

Hello @eliasecchig, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the project's compatibility with Windows environments by addressing various issues related to executing gcloud CLI commands. It centralizes the logic for finding the gcloud executable and ensures that all subprocess calls interacting with gcloud are correctly configured for Windows, particularly by setting shell=True where required. These changes ensure that key CLI commands like create and setup-cicd now work reliably on Windows, completing the ongoing effort to enhance cross-platform support.

Highlights

  • Enhanced Windows Compatibility: Implemented comprehensive fixes to ensure all gcloud CLI commands function correctly on Windows, addressing issues with executable path resolution and subprocess call configurations.
  • Centralized gcloud Command Resolution: Introduced a new utility function, _get_gcloud_cmd, in gcp.py to consistently resolve the gcloud executable path across different operating systems, including specific handling for Windows environments where shutil.which might fail.
  • Improved run_command Utility: The run_command function in cicd.py now automatically detects gcloud commands and applies the necessary Windows compatibility fixes (e.g., using shell=True and the resolved gcloud path), streamlining command execution.
  • Encoding Consistency for File Operations: Added encoding='utf-8' to open() calls in several files (load_test.py, deploy.py) to ensure consistent and correct handling of file I/O, preventing potential encoding-related errors.
  • Robust Error Handling for gcloud Login: Added a try-except block around gcloud auth login calls to gracefully handle potential subprocess.CalledProcessError or FileNotFoundError exceptions, improving user experience during credential changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 14 '25 23:12 gemini-code-assist[bot]

/gemini review

eliasecchig avatar Dec 14 '25 23:12 eliasecchig