agent-starter-pack icon indicating copy to clipboard operation
agent-starter-pack copied to clipboard

Makefile installs uv and modifies user's bashrc

Open aabmass opened this issue 10 months ago • 1 comments

The makefile will curl | bash the uv installer script if uv is not available on the system https://github.com/GoogleCloudPlatform/agent-starter-pack/blob/e22ea483b6b82b18cc84b2a1ad5064f9de79bd41/src/base_template/Makefile#L2

I also like uv, but this might really throw some users since it installs into their home directory and modifies their shell profile (~/.bashrc). Maybe doing https://docs.astral.sh/uv/configuration/installer/#unmanaged-installations if uv is not on path would be cleaner.

aabmass avatar Mar 05 '25 15:03 aabmass

Thanks a lot for raising the first issue on the repo @aabmass. I am well noting this, it's something which I agree needs to looked at. Do you think perhaps an interactive prompt asking for confirmation might be better?

eliasecchig avatar Mar 08 '25 14:03 eliasecchig