Open_Data_QnA icon indicating copy to clipboard operation
Open_Data_QnA copied to clipboard

Support Google Cloud Spanner (GoogleSQL dialect)

Open rafi-rr opened this issue 1 year ago • 3 comments

This PR adds support for Spanner as an additional database option in parallel to BigQuery and PostgreSQL. It accesses a Spanner instance and then is capable of using all databases within that instance as data sources. Furthermore, the embeddings database is defined separately as a separate database.

rafi-rr avatar Sep 11 '24 08:09 rafi-rr

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 11 '24 08:09 google-cla[bot]

Thanks @5Y5TEM Taking care of this now.

rafi-rr avatar Oct 14 '24 20:10 rafi-rr

@5Y5TEM Verified on my end following conflict resolution.

rafi-rr avatar Oct 14 '24 20:10 rafi-rr

@rafi-rr I have resolved all the issues and merged your code in the spanner branch: https://github.com/GoogleCloudPlatform/Open_Data_QnA/tree/spanner

Once the team is done with testing, we will merge it to main.

Thank you for contributing! I will resolve this PR for now.

5Y5TEM avatar Oct 15 '24 09:10 5Y5TEM