DataflowTemplates icon indicating copy to clipboard operation
DataflowTemplates copied to clipboard

[DO NOT MERGE] Validate Beam 2.70.0rc2

Open Amar3tto opened this issue 1 month ago • 3 comments

Amar3tto avatar Dec 10 '25 08:12 Amar3tto

Summary of Changes

Hello @Amar3tto, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, marked as '[DO NOT MERGE]', serves as a validation branch to test the compatibility and functionality of the project with the upcoming Apache Beam 2.70.0 release candidate. It involves updating both Java and Python Beam dependencies, configuring a new Maven repository for the release candidate, and making necessary adjustments to Python package requirements to ensure a smooth transition and proper operation with the new Beam version.

Highlights

  • Apache Beam Version Upgrade: The project's core Apache Beam dependency has been updated to version 2.70.0 for Java and 2.70.0rc2 for Python across various configuration files.
  • Maven Repository Configuration: A new Apache Maven repository URL (https://repository.apache.org/content/repositories/orgapachebeam-1417) has been added to the pom.xml to support the Beam release candidate.
  • Python Dependency Refinements: Several Python dependencies were adjusted in requirements.txt files, including the addition of google-cloud-kms and the removal of crcmod, docopt, hdfs, jsonschema, jsonschema-specifications, pydot, redis, referencing, and rpds-py.
  • Maven Profile Activation Update: The validateCandidate Maven profile's activation logic was changed from activeByDefault=false to jdk=[1.), indicating it will now activate for any JDK version 1 or greater.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 10 '25 08:12 gemini-code-assist[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 50.39%. Comparing base (716bd4a) to head (58d7f8b). :warning: Report is 9 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3091      +/-   ##
============================================
- Coverage     50.41%   50.39%   -0.03%     
- Complexity     5023     5398     +375     
============================================
  Files           970      970              
  Lines         59606    59606              
  Branches       6507     6507              
============================================
- Hits          30052    30038      -14     
- Misses        27432    27443      +11     
- Partials       2122     2125       +3     
Components Coverage Δ
spanner-templates 70.60% <ø> (-0.07%) :arrow_down:
spanner-import-export 68.84% <ø> (-0.17%) :arrow_down:
spanner-live-forward-migration 80.03% <ø> (ø)
spanner-live-reverse-replication 77.51% <ø> (ø)
spanner-bulk-migration 88.25% <ø> (ø)
see 5 files with indirect coverage changes
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 10 '25 08:12 codecov[bot]

[ERROR] Failures: 2025-12-10T10:30:07.3944492Z [ERROR] PubSubToBigQueryYamlIT.testPubSubToBigQuery:88->basePubSubToBigQuery:139 value of : result.check if meets all conditions 2025-12-10T10:30:07.3945454Z expected : CONDITION_MET 2025-12-10T10:30:07.3945794Z but was : TIMEOUT

Amar3tto avatar Dec 10 '25 13:12 Amar3tto

|[v2/sourcedb-to-spanner/target/surefire-reports/TEST-com.google.cloud.teleport.v2.templates.CassandraAllDataTypesIT.xml](#user-content-r39)||1 ❌||803s|

Amar3tto avatar Dec 12 '25 19:12 Amar3tto

|[v2/sourcedb-to-spanner/target/surefire-reports/TEST-com.google.cloud.teleport.v2.templates.CassandraAllDataTypesIT.xml](#user-content-r39)||1 ❌||803s|

This appeared after the rebase, so I don't think the RC is the cause.

Amar3tto avatar Dec 15 '25 13:12 Amar3tto

Job ID: 2025-12-12_12_20_15-14033636291513510713

Failed message:

"message":"com.google.cloud.teleport.v2.common.UncaughtExceptionLogger - The template launch failed.
java.lang.IllegalArgumentException: Unknown Cassandra Driver Option advanced.load-balancing-policy.dc-failover.preferred-remote-dcs. Supported Options
...
advanced.load-balancing-policy.dc-failover.max-nodes-per-remote-dc=TypedDriverOption[rawOption=LOAD_BALANCING_DC_FAILOVER_MAX_NODES_PER_REMOTE_DC, expectedType=java.lang.Integer], advanced.load-balancing-policy.dc-failover.allow-for-local-consistency-levels=TypedDriverOption[rawOption=LOAD_BALANCING_DC_FAILOVER_ALLOW_FOR_LOCAL_CONSISTENCY_LEVELS, expectedType=java.lang.Boolean

And this test has been disabled: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/3092

shunping avatar Dec 15 '25 15:12 shunping

"message":"com.google.cloud.teleport.v2.common.UncaughtExceptionLogger - The template launch failed. java.lang.IllegalArgumentException: Unknown Cassandra Driver Option advanced.load-balancing-policy.dc-failover.preferred-remote-dcs. Supported Options ... advanced.load-balancing-policy.dc-failover.max-nodes-per-remote-dc=TypedDriverOption[rawOption=LOAD_BALANCING_DC_FAILOVER_MAX_NODES_PER_REMOTE_DC, expectedType=java.lang.Integer], advanced.load-balancing-policy.dc-failover.allow-for-local-consistency-levels=TypedDriverOption[rawOption=LOAD_BALANCING_DC_FAILOVER_ALLOW_FOR_LOCAL_CONSISTENCY_LEVELS, expectedType=java.lang.Boolean


And this test has been disabled: #3092

It was failing on main branch as well so I think we can mark templates validation as passed

Abacn avatar Dec 15 '25 16:12 Abacn