DataflowTemplates icon indicating copy to clipboard operation
DataflowTemplates copied to clipboard

Add yaml blueprints publishing to GCS

Open derrickaw opened this issue 3 weeks ago • 9 comments

  1. Piggybacking the release process to include publishing the yaml blueprints to a GCS bucket for further processing later on.
  2. Will set the publishYamlBlueprints parameter to true in the next PR.
  3. mvn -pl plugins/templates-maven-plugin -Dtest=TemplatesReleaseMojoTest test

derrickaw avatar Dec 04 '25 21:12 derrickaw

Summary of Changes

Hello @derrickaw, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the TemplatesReleaseMojo Maven plugin to include the capability of publishing YAML-based blueprints to Google Cloud Storage. This enhancement provides a unified release mechanism for both traditional Dataflow templates and new YAML blueprints, controlled by a dedicated configuration parameter. The changes involve adding necessary GCS dependencies, implementing the upload logic, and ensuring proper validation and testing of the new feature.

Highlights

  • YAML Blueprint Publishing: The Maven plugin now supports publishing YAML blueprints to Google Cloud Storage, alongside traditional Dataflow templates.
  • New Configuration Parameter: A new Maven parameter, publishYamlBlueprints, has been introduced to enable or disable this new publishing functionality.
  • Google Cloud Storage Integration: Added google-cloud-storage dependency and integrated GCS client logic to handle the upload of YAML files.
  • Unit Testing for YAML Publishing: A new unit test has been added to verify the correct behavior of the YAML blueprint publishing process, including mocking GCS interactions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 04 '25 21:12 gemini-code-assist[bot]

Codecov Report

:x: Patch coverage is 47.91667% with 25 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 50.45%. Comparing base (8e697e1) to head (960daa7). :warning: Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...ud/teleport/plugin/maven/TemplatesReleaseMojo.java 47.91% 19 Missing and 6 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3056      +/-   ##
============================================
+ Coverage     50.25%   50.45%   +0.20%     
- Complexity     5019     5027       +8     
============================================
  Files           967      969       +2     
  Lines         59261    59580     +319     
  Branches       6458     6497      +39     
============================================
+ Hits          29779    30063     +284     
- Misses        27377    27380       +3     
- Partials       2105     2137      +32     
Components Coverage Δ
spanner-templates 70.58% <ø> (+0.13%) :arrow_up:
spanner-import-export 68.85% <ø> (-0.13%) :arrow_down:
spanner-live-forward-migration 80.02% <ø> (+0.33%) :arrow_up:
spanner-live-reverse-replication 77.44% <ø> (+0.36%) :arrow_up:
spanner-bulk-migration 88.27% <ø> (-0.07%) :arrow_down:
Files with missing lines Coverage Δ
...ud/teleport/plugin/maven/TemplatesReleaseMojo.java 47.36% <47.91%> (+47.36%) :arrow_up:

... and 20 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 04 '25 21:12 codecov[bot]

/gemini review

derrickaw avatar Dec 05 '25 16:12 derrickaw

/gemini review

derrickaw avatar Dec 05 '25 19:12 derrickaw

/gemini review

derrickaw avatar Dec 05 '25 20:12 derrickaw

/gemini review

derrickaw avatar Dec 05 '25 20:12 derrickaw

/gemini review

derrickaw avatar Dec 05 '25 20:12 derrickaw

/gemini review

derrickaw avatar Dec 05 '25 20:12 derrickaw

/gemini review

derrickaw avatar Dec 05 '25 20:12 derrickaw