DataflowTemplates icon indicating copy to clipboard operation
DataflowTemplates copied to clipboard

feat: add support for custom certificate path

Open fbiville opened this issue 1 year ago • 1 comments

This is an extra attribute that can now be added to the connection JSON information.

Fixes #1794

fbiville avatar Aug 21 '24 10:08 fbiville

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 43.99%. Comparing base (7294b49) to head (da5433c). Report is 95 commits behind head on main.

Files with missing lines Patch % Lines
...rt/v2/neo4j/model/connection/ConnectionParams.java 16.66% 6 Missing and 4 partials :warning:
...ud/teleport/v2/neo4j/database/Neo4jConnection.java 0.00% 4 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1805      +/-   ##
============================================
- Coverage     43.99%   43.99%   -0.01%     
- Complexity     3451     3453       +2     
============================================
  Files           830      830              
  Lines         49156    49167      +11     
  Branches       5153     5155       +2     
============================================
+ Hits          21628    21630       +2     
- Misses        25871    25879       +8     
- Partials       1657     1658       +1     
Components Coverage Δ
spanner-templates 63.53% <ø> (+<0.01%) :arrow_up:
spanner-import-export 63.75% <ø> (+0.02%) :arrow_up:
spanner-live-forward-migration 74.83% <ø> (ø)
spanner-live-reverse-replication 68.55% <ø> (ø)
spanner-bulk-migration 84.27% <ø> (ø)
Files with missing lines Coverage Δ
.../neo4j/model/connection/BasicConnectionParams.java 26.31% <100.00%> (ø)
...neo4j/model/connection/BearerConnectionParams.java 31.25% <100.00%> (ø)
...neo4j/model/connection/CustomConnectionParams.java 33.33% <100.00%> (ø)
...o4j/model/connection/KerberosConnectionParams.java 31.25% <100.00%> (ø)
...neo4j/model/connection/NoAuthConnectionParams.java 33.33% <100.00%> (ø)
...ud/teleport/v2/neo4j/database/Neo4jConnection.java 73.33% <0.00%> (-2.16%) :arrow_down:
...rt/v2/neo4j/model/connection/ConnectionParams.java 28.57% <16.66%> (-9.90%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Aug 21 '24 10:08 codecov[bot]

No customer feedback, closing this for now.

fbiville avatar Nov 29 '24 13:11 fbiville