DataflowTemplates icon indicating copy to clipboard operation
DataflowTemplates copied to clipboard

Add troubleshooting block to template readme's

Open Polber opened this issue 1 year ago • 2 comments

This also regenerates the template README's - this means any files in v1/, v2/, python/ and yaml/ are auto-generated and can be ignored from review.

UPDATE: Added minimal logic (and tests) to skip metadata and image spec generation (as well as skip doc generation) for stage-only images. At this point, the only stage-only image affected is Job Builder image.

Polber avatar Jul 26 '24 18:07 Polber

Codecov Report

:x: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 45.09%. Comparing base (babf762) to head (6310ac6). :warning: Report is 594 commits behind head on main.

Files with missing lines Patch % Lines
.../cloud/teleport/plugin/TemplateSpecsGenerator.java 16.66% 4 Missing and 1 partial :warning:

:x: Your patch status has failed because the patch coverage (16.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1751      +/-   ##
============================================
+ Coverage     45.04%   45.09%   +0.05%     
- Complexity     3601     3933     +332     
============================================
  Files           835      835              
  Lines         49684    49696      +12     
  Branches       5229     5231       +2     
============================================
+ Hits          22378    22409      +31     
+ Misses        25639    25622      -17     
+ Partials       1667     1665       -2     
Components Coverage Δ
spanner-templates 66.25% <50.00%> (+0.12%) :arrow_up:
spanner-import-export 64.20% <50.00%> (+0.38%) :arrow_up:
spanner-live-forward-migration 76.18% <ø> (ø)
spanner-live-reverse-replication 76.54% <ø> (ø)
spanner-bulk-migration 85.55% <ø> (ø)
Files with missing lines Coverage Δ
...a/com/google/cloud/teleport/metadata/Template.java 100.00% <ø> (ø)
.../cloud/teleport/plugin/TemplateSpecsGenerator.java 40.49% <16.66%> (+0.66%) :arrow_up:

... and 5 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 26 '24 18:07 codecov[bot]

This pull request has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time. Thank you for your contributions.

github-actions[bot] avatar Apr 22 '25 02:04 github-actions[bot]

This pull request has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time. Thank you for your contributions.

github-actions[bot] avatar Oct 20 '25 02:10 github-actions[bot]