DataflowTemplates
DataflowTemplates copied to clipboard
Support conversion of RFC4180 CSV
This PR improves StringToGenericRecordFn, which uses Guava's Splitter
, to split a CSV string. This method does not support RFC4180 CSV which could have the comma delimiter within the field value, e.g. 007,"CA,AZ",26.23
.
This requires the Apache Commons CSV library to be updated as well as CSVRecord.values
method is not public in 1.8.
Codecov Report
Attention: Patch coverage is 62.50000%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 41.25%. Comparing base (
7189f1d
) to head (cd234df
). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1514 +/- ##
============================================
- Coverage 41.26% 41.25% -0.01%
+ Complexity 2929 2927 -2
============================================
Files 763 763
Lines 44372 44378 +6
Branches 4752 4752
============================================
Hits 18308 18308
- Misses 24521 24525 +4
- Partials 1543 1545 +2
Components | Coverage Δ | |
---|---|---|
spanner-templates | 61.35% <ø> (-0.03%) |
:arrow_down: |
spanner-import-export | 64.38% <ø> (-0.07%) |
:arrow_down: |
spanner-live-forward-migration | 73.88% <ø> (ø) |
|
spanner-live-reverse-replication | 49.66% <ø> (ø) |
|
spanner-bulk-migration | 82.07% <ø> (ø) |
Files | Coverage Δ | |
---|---|---|
...le/cloud/teleport/v2/transforms/CsvConverters.java | 70.80% <62.50%> (-0.52%) |
:arrow_down: |