DataflowTemplates icon indicating copy to clipboard operation
DataflowTemplates copied to clipboard

Add groupName attribute where it's needed

Open akashorabek opened this issue 1 year ago • 1 comments

akashorabek avatar Apr 24 '24 13:04 akashorabek

@an2x I added the value Source or Target for the attribute groupName for those template parameters that are obvious from the method name or description. For parameters that are not obvious, I decided not to add the groupName attribute. Could you please check if they are correctly specified?

akashorabek avatar Apr 29 '24 19:04 akashorabek

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.26%. Comparing base (b910d17) to head (f1cde6e). Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1471      +/-   ##
============================================
- Coverage     40.27%   40.26%   -0.01%     
+ Complexity     2817     2814       -3     
============================================
  Files           740      740              
  Lines         42899    42899              
  Branches       4604     4604              
============================================
- Hits          17276    17272       -4     
- Misses        24133    24135       +2     
- Partials       1490     1492       +2     
Components Coverage Δ
spanner-templates 56.80% <ø> (-0.04%) :arrow_down:
spanner-import-export 65.52% <ø> (-0.09%) :arrow_down:
spanner-live-forward-migration 63.17% <ø> (ø)
spanner-live-reverse-replication 42.95% <ø> (ø)
spanner-bulk-migration 69.97% <ø> (ø)
Files Coverage Δ
...google/cloud/teleport/bigtable/AvroToBigtable.java 62.26% <ø> (ø)
...google/cloud/teleport/bigtable/BigtableToAvro.java 36.36% <ø> (ø)
...google/cloud/teleport/bigtable/BigtableToJson.java 63.33% <ø> (ø)
...gle/cloud/teleport/bigtable/BigtableToParquet.java 41.86% <ø> (ø)
.../teleport/bigtable/BigtableToVectorEmbeddings.java 78.33% <ø> (ø)
...e/cloud/teleport/bigtable/CassandraToBigtable.java 0.00% <ø> (ø)
...gle/cloud/teleport/bigtable/ParquetToBigtable.java 57.14% <ø> (ø)
.../google/cloud/teleport/spanner/ExportPipeline.java 0.00% <ø> (ø)
.../google/cloud/teleport/spanner/ImportPipeline.java 0.00% <ø> (ø)
...gle/cloud/teleport/spanner/TextImportPipeline.java 0.00% <ø> (ø)
... and 53 more

... and 2 files with indirect coverage changes

codecov[bot] avatar May 08 '24 23:05 codecov[bot]

PR was split into 3 parts: https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1539 https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1541 https://github.com/GoogleCloudPlatform/DataflowTemplates/pull/1542

Amar3tto avatar May 13 '24 11:05 Amar3tto