[Bug]: Spanner resource manager broken for SpannerIOLT

[Abacn]

Related Template(s)

N/A

Template Version

N/A

What happened?

GCP IO performance benchmark used for validation for SpannerIO no longer working. This command used to work:

[main] INFO org.apache.beam.it.gcp.spanner.SpannerResourceManager - Creating instance testspa-20240209-223741-100149 in project apache-beam-testing.
[main] INFO org.apache.beam.it.gcp.spanner.SpannerResourceManager - Deleting instance testspa-20240209-223741-100149...
[main] INFO org.apache.beam.it.common.utils.ResourceManagerUtils - Cleaning up resource manager SpannerResourceManager
[main] INFO org.apache.beam.it.gcp.spanner.SpannerResourceManager - Deleting instance testspa-20240209-223741-100149...
[main] ERROR org.apache.beam.it.common.utils.ResourceManagerUtils - Error cleaning the resource manager SpannerResourceManager
[main] INFO org.apache.beam.it.gcp.dataflow.AbstractPipelineLauncher - Cleaning up Dataflow jobs...
[main] INFO org.apache.beam.it.gcp.dataflow.AbstractPipelineLauncher - Dataflow jobs successfully cleaned up.
[main] INFO org.apache.beam.it.gcp.dataflow.AbstractPipelineLauncher - Cleaning up Dataflow jobs...
[main] INFO org.apache.beam.it.gcp.dataflow.AbstractPipelineLauncher - Dataflow jobs successfully cleaned up.
[main] INFO org.apache.beam.it.gcp.monitoring.MonitoringClient - Attempting to cleanup monitoring client.
[main] INFO org.apache.beam.it.gcp.monitoring.MonitoringClient - Monitoring client successfully cleaned up.
[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 6.632 s <<< FAILURE! - in org.apache.beam.it.gcp.spanner.SpannerIOLT
[ERROR] testSpannerWriteAndRead(org.apache.beam.it.gcp.spanner.SpannerIOLT)  Time elapsed: 6.374 s  <<< ERROR!
org.apache.beam.it.gcp.spanner.SpannerResourceManagerException: Failed to delete instance.
	at org.apache.beam.it.gcp.spanner.SpannerResourceManager.cleanupAll(SpannerResourceManager.java:435)
	at org.apache.beam.it.gcp.spanner.SpannerResourceManager.maybeCreateInstance(SpannerResourceManager.java:181)
	at org.apache.beam.it.gcp.spanner.SpannerResourceManager.executeDdlStatement(SpannerResourceManager.java:268)
	at org.apache.beam.it.gcp.spanner.SpannerIOLT.setup(SpannerIOLT.java:105)
	...
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:413)
Caused by: com.google.cloud.spanner.SpannerException: INVALID_ARGUMENT: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Project 'project:apache-beam-testing,apache-beam-testing' not found or deleted.
	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerExceptionPreformatted(SpannerExceptionFactory.java:291)
	...
	at com.google.cloud.spanner.InstanceAdminClientImpl.deleteInstance(InstanceAdminClientImpl.java:250)
	at org.apache.beam.it.gcp.spanner.SpannerResourceManager.lambda$cleanupAll$5(SpannerResourceManager.java:428)
	...
	at org.apache.beam.it.gcp.spanner.SpannerResourceManager.cleanupAll(SpannerResourceManager.java:428)
	... 37 more
Caused by: java.util.concurrent.ExecutionException: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Project 'project:apache-beam-testing,apache-beam-testing' not found or deleted.
	...
	... 47 more
Caused by: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Project 'project:apache-beam-testing,apache-beam-testing' not found or deleted.
	...
Caused by: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Project 'project:apache-beam-testing,apache-beam-testing' not found or deleted.
	at io.grpc.Status.asRuntimeException(Status.java:537)
	... 32 more

Now it fails to create the instance. The problem is that the project name get passed to spanner became 'project:apache-beam-testing,apache-beam-testing'

The only change since last validation was #826, introduced breaking change to the resource manager.

Relevant log output

No response