prerender-loader icon indicating copy to clipboard operation
prerender-loader copied to clipboard

Fix for multiple chunks emitting to ssr-bundle.js

Open dwoznicki opened this issue 4 years ago • 5 comments

Prerendering multiple entries in conjunction with the {{prerender}} injection point results in the following error:

Error: Conflict: Multiple chunks emit assets to the same filename ssr-bundle.js

even when an entry is specified in the loader query string for HtmlWebpackPlugin template.

const plugin = new HtmlWebpackPlugin({
  // ...
  template: `!!prerender-loader?string&entry=${entryFile}!./src/template.html`
});

This appears to be caused by this block clobbering the original entry and changing it to undefined.

if (matches) {
  inject = true;
  options.entry = matches[1]; // <-- matches[1] is `undefined`
}

I'm not sure what the original intention here is, but only reassigning the entry if it's not already set probably fixes the issue. I can't say for sure because I can't build due to https://github.com/developit/microbundle/issues/74. Making this change directly to dist/prerender-loader.js worked for me.

Fixes https://github.com/GoogleChromeLabs/prerender-loader/issues/29#issuecomment-489229652

dwoznicki avatar May 14 '20 19:05 dwoznicki

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

googlebot avatar May 14 '20 19:05 googlebot

@googlebot I signed it!

dwoznicki avatar May 14 '20 19:05 dwoznicki

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar May 14 '20 19:05 googlebot

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar May 14 '20 19:05 googlebot

Wow I was about to open a similar PR and https://github.com/developit/microbundle/issues/74 stopped me from making sure it works.

anyway- thumbs up!

vzaidman avatar May 21 '20 12:05 vzaidman