prerender-loader icon indicating copy to clipboard operation
prerender-loader copied to clipboard

React v16.7.0-alpha, hooks

Open ezekielchentnik opened this issue 6 years ago • 5 comments

Something up with the latest react hooks stuff. I'm trying to narrow it down but no luck so far.

Error: Uncaught [TypeError: Cannot read property 'network' of null]

result = window.eval(output + '\nPRERENDER_RESULT');

ezekielchentnik avatar Nov 29 '18 23:11 ezekielchentnik

Seems like to be a syntax error. What version of Node are you running?

developit avatar Dec 03 '18 19:12 developit

node 11.3.0

ezekielchentnik avatar Dec 03 '18 20:12 ezekielchentnik

My prerender entry is running regular react-dom render. Hooks are not yet support for 'react-dom/server' e.g. 'renderToString'

const prerender = ({ url = "/", title = "Studio" }: Props) => {

  // setup stuff ...
  
  // during dev we don't prerender
  return process.env.NODE_ENV === "development"
    ? ""
    : render(
        <Provider value={provide}>
          <App />
        </Provider>,
         window.document.getElementById("root")
      );
};

export default prerender;

ezekielchentnik avatar Dec 03 '18 20:12 ezekielchentnik

Did you ever find the root cause for this? There isn't really anything in prerender-loader that seems like it would cause this. Maybe it's an issue with React 16.7 + JSDOM?

developit avatar Feb 22 '19 13:02 developit

I'm using 16.8.0-alpha.0 and hooks, does not seem any weirdness yet. Everything works fine.

edwardfxiao avatar Feb 22 '19 16:02 edwardfxiao