ndb icon indicating copy to clipboard operation
ndb copied to clipboard

Fixed Broken Image Url - Chrome Devtools Logo

Open kmanadkat opened this issue 2 years ago • 4 comments

Proposed Changes

Image url was pointing to 404 status resource. I went to official ChromeDevTools repository, referred to the svg logo present in README.md and made the correction to README.md file of this repository.

Ensured rest of the attributes: align="right" and height="200" stays the same.

Screenshot

ChromeDevtools Logo

kmanadkat avatar May 26 '22 07:05 kmanadkat

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 26 '22 07:05 google-cla[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Resolved.

kmanadkat avatar May 26 '22 07:05 kmanadkat

@paulirish or @ak239 could one of you please review this PR?

It ain't much, but it is something :D

PS: I was checking out ndb package in npm and found the image was broken there, thought of submitting a quick fix.

kmanadkat avatar May 26 '22 07:05 kmanadkat

@paulirish, @ak239 is anything missing in this PR ?

kmanadkat avatar Jun 17 '22 10:06 kmanadkat