ndb icon indicating copy to clipboard operation
ndb copied to clipboard

`ndb yarn <script>` broken on Windows

Open connorjclark opened this issue 6 years ago • 3 comments

Steps to reproduce

Tell us about your environment:

  • ndb version: 1.1.4
  • Platform / OS version: Windows 10
  • Node.js version: 10.16.0

this node 12 feature broke debugging node 10: https://github.com/GoogleChromeLabs/ndb/commit/451e01c8181742c801551f6e3068939e67557f73

I get this error:

Request NodeRuntime.notifyWhenWaitingForDisconnect failed. {"code":-32601,"message":"'NodeRuntime.notifyWhenWaitingForDisconnect' wasn't found"}
  1. should fix this
  2. why didn't travis running node 10 catch this?

connorjclark avatar Jul 21 '19 01:07 connorjclark

cc @ak239

connorjclark avatar Jul 21 '19 01:07 connorjclark

This error by itself should not beak debugging. Frontend is ready for this error and use another signal when this method is not available. What exactly is broken?

alexkozy avatar Jul 21 '19 16:07 alexkozy

Of course, you're right :)

here's what I see

package.json

{
  "scripts": {
    "test": "node main.js"
  }
}

main.js

const a = 'test';
debugger;
console.log(a);

ndb node main.js works fine. ndb yarn test does not. No issue on my Mac.

connorjclark avatar Jul 21 '19 18:07 connorjclark