lighthousebot icon indicating copy to clipboard operation
lighthousebot copied to clipboard

Run on non-PR's

Open kontrollanten opened this issue 6 years ago • 4 comments

Thanks for a great package! In my case my site is not deployed through Travis, instead my deploy service (Netlify) triggers a web hook to run e2e and lighthouse after deploy.

Would it be possible to allow this to be ran on non-pull request events in Travis? Then it could fetch PR number, etc from the GH API; like https://api.github.com/repos/ebidel/lighthouse-ci/pulls

kontrollanten avatar Jun 08 '18 05:06 kontrollanten

What's the use case you have in mind?

On Thu, Jun 7, 2018, 10:27 PM kontrollanten [email protected] wrote:

Thanks for a great package! Would it be possible to allow this to be ran on non-pull request events in Travis? Then it could fetch PR number, etc from the GH API; like https://api.github.com/repos/ebidel/lighthouse-ci/pulls

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ebidel/lighthouse-ci/issues/34, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOigIrv1gIdOJBM_jpKtc85ITl7kcStks5t6gtZgaJpZM4Ufg2s .

ebidel avatar Jun 08 '18 15:06 ebidel

I'm triggering my Travis build with the API after I've deployed my PR preview

kontrollanten avatar Jun 08 '18 16:06 kontrollanten

I made a fork to do a poc; https://github.com/kontrollanten/lighthouse-ci/commit/b6ad518a563acc54101e06c7d38b55b3c0f3d2c4

Please let me know if you want me to do a PR

kontrollanten avatar Jun 08 '18 20:06 kontrollanten

Ah neat. Yea, a PR would be great. Changes are pretty minimal and I like the idea of making this more configurable :)

ebidel avatar Jun 08 '18 23:06 ebidel