jsbi icon indicating copy to clipboard operation
jsbi copied to clipboard

Invalid sourcemap due to missing TS output files in package

Open justingrant opened this issue 2 years ago • 3 comments

While diagnosing and fixing https://github.com/js-temporal/temporal-polyfill/issues/192, I found that JSBI has the same bug: the package's sourcemap points to files that don't exist in the package. This causes debug console errors in some environments like the VSCode debugger.

For example, here's what I see in the debug console when I run my JSBI-using app in the VSCode debugger:

Could not read source map for file:///Users/[redacted for privacy]/node_modules/jsbi/tsc-out/jsbi.mjs: ENOENT: no such file or directory, open '/Users/[redacted for privacy]/node_modules/jsbi/tsc-out/jsbi.js.map'

The fix that I proposed in https://github.com/js-temporal/temporal-polyfill/pull/193 is to add the tsc-out folder to the package. The lib folder should also be added. I suspect that the same fix may work here too. There may be other fixes possible too.

justingrant avatar Nov 13 '22 21:11 justingrant

Would you be up for submitting a patch?

mathiasbynens avatar Nov 14 '22 07:11 mathiasbynens

I'm less confident that I understand the bundler config in this repo than in https://github.com/js-temporal/temporal-polyfill. In particular, I'm not sure how the browser-facing bundles work here, and I was worried that increasing the size of the browser bundle might be bad. So I was thinking that it might be better for someone who knows this repo better (like @12wrigja?) to PR a fix here?

justingrant avatar Nov 14 '22 07:11 justingrant

I'll try and find some time this week to send a PR for this (same for Temporal).

12wrigja avatar Nov 14 '22 16:11 12wrigja