critters icon indicating copy to clipboard operation
critters copied to clipboard

Animation keyframe detection is not using the correct index in the iterator [v1.3.3]

Open pathacks opened this issue 4 years ago • 1 comments

For any CSS where there is animation declarations, the library will throw an error if the index i is out of bounds of the Array of critical keyframe names, since it should be iterating using index j instead.

This issue was addressed in this commit which was released in v2.4.0, however this fix was never applied to the 1.x codeline, of which there are several very popular packages still using it (e.g. preact-cli)

Can we please have a hotfix release for 1.x, with that fix included?

pathacks avatar Sep 02 '19 03:09 pathacks

Thanks for the patch. I need to re-target this to a new branch that will track the 1.x line.

developit avatar Oct 16 '19 17:10 developit