comlink icon indicating copy to clipboard operation
comlink copied to clipboard

Failing test for StringChannel with MessagePorts

Open felixfbecker opened this issue 5 years ago • 2 comments

I couldn't get the new experimental string channel to work and was able to write a test case that shows the issue.

Easiest du review with ignoring whitespace: https://github.com/GoogleChromeLabs/comlink/pull/458/files?diff=unified&w=1

felixfbecker avatar Apr 30 '20 09:04 felixfbecker

Ah, interesting. Yeah I was expecting the transfer behavior to be buggy somewhere, but it was good enough for my experiment :P

Happy to accept PRs for it, but I currently don’t have the time to maintain that.

surma avatar Apr 30 '20 09:04 surma

Makes sense, just thought it might be helpful. Given we were only using string channel to make it work in browser extension, I'll focus on trying a direct solution for that instead https://github.com/GoogleChromeLabs/comlink/issues/438#issuecomment-621721424

felixfbecker avatar Apr 30 '20 09:04 felixfbecker