comlink-loader
comlink-loader copied to clipboard
Fix function type error in README
Fix type error of greet
function in README.
See also #1.
Also, TypeScript does not allow the addition of ".ts"
when importing *.ts
.
https://www.typescriptlang.org/docs/handbook/modules.html#import
I also fix the README small mistake about this behavior.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@developit I’d love your feedback, please review my PR.
Maybe in the webpack.config.js
there should also be a comment about additional loaders for typescript, like ts-loader
?
So the config looks like:
module.exports = {
module: {
rules: [
{
test: /\.worker\.(js|ts)$/i,
use: [{
loader: 'comlink-loader',
options: {
singleton: true
}
},
"ts-loader"]
}
]
}
}
Otherwise there will / may be build-failures like
Module parse failed: Unexpected token (2:25)
File was processed with these loaders:
* ../../node_modules/comlink-loader/dist/comlink-worker-loader.js
You may need an additional loader to handle the result of these loaders.
| import { expose } from 'comlink';
...
@gfoidl The README is correct in this regard, as it works if you write the comlink-loader
first, as shown below.
module.exports = {
module: {
rules: [
{
test: /\.worker\.[tj]s$/,
loader: "comlink-loader?singleton",
},
{
test: /\.[tj]sx?$/,
loader: "ts-loader",
exclude: /node_modules/,
}
]
}
}
Ahhh, that's good to know. Thank you very much! 👍 😃