chromium-bidi
chromium-bidi copied to clipboard
feat(bidi): remove non-spec-compliant bidi commands
Solves #2844
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
@sadym-chromium PTAL
Removing deprecated channel should be done after 2025-03-31, so that give everyone using it some time to switch to the new API
This TODO should be addressed as well: https://github.com/GoogleChromeLabs/chromium-bidi/blob/a18cd6f567fc395e25904b84d5b74af464f0ec6d/src/protocol/chromium-bidi.ts#L154
This TODO should be addressed as well:
https://github.com/GoogleChromeLabs/chromium-bidi/blob/a18cd6f567fc395e25904b84d5b74af464f0ec6d/src/protocol/chromium-bidi.ts#L154
@sadym-chromium PTAL I have implemented this TODO
@sadym-chromium Please review this PR and share the valuable feedback
@sadym-chromium Please review this PR and share the valuable feedback
please fix rebase first before I can review the PR. Also please note that even after completion, this PR can be merged only after 2025-03-31
Addressed in #3288 and #3289