chromium-bidi icon indicating copy to clipboard operation
chromium-bidi copied to clipboard

feat(bidi): remove non-spec-compliant bidi commands

Open anshikavashistha opened this issue 10 months ago • 7 comments

Solves #2844

anshikavashistha avatar Jan 23 '25 20:01 anshikavashistha

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 23 '25 20:01 google-cla[bot]

@sadym-chromium PTAL

anshikavashistha avatar Jan 23 '25 21:01 anshikavashistha

Removing deprecated channel should be done after 2025-03-31, so that give everyone using it some time to switch to the new API

sadym-chromium avatar Jan 24 '25 14:01 sadym-chromium

This TODO should be addressed as well: https://github.com/GoogleChromeLabs/chromium-bidi/blob/a18cd6f567fc395e25904b84d5b74af464f0ec6d/src/protocol/chromium-bidi.ts#L154

sadym-chromium avatar Jan 24 '25 14:01 sadym-chromium

This TODO should be addressed as well:

https://github.com/GoogleChromeLabs/chromium-bidi/blob/a18cd6f567fc395e25904b84d5b74af464f0ec6d/src/protocol/chromium-bidi.ts#L154

@sadym-chromium PTAL I have implemented this TODO

anshikavashistha avatar Jan 31 '25 07:01 anshikavashistha

@sadym-chromium Please review this PR and share the valuable feedback

anshikavashistha avatar Feb 04 '25 19:02 anshikavashistha

@sadym-chromium Please review this PR and share the valuable feedback

please fix rebase first before I can review the PR. Also please note that even after completion, this PR can be merged only after 2025-03-31

sadym-chromium avatar Feb 05 '25 09:02 sadym-chromium

Addressed in #3288 and #3289

sadym-chromium avatar Apr 08 '25 07:04 sadym-chromium