chromium-bidi icon indicating copy to clipboard operation
chromium-bidi copied to clipboard

Implement `session.new` command

Open mathiasbynens opened this issue 2 years ago • 7 comments

https://w3c.github.io/webdriver-bidi/#command-session-new

mathiasbynens avatar Apr 29 '22 11:04 mathiasbynens

This is blocking #110: the Firefox implementation strictly follows the spec, and requires a session to be created before accepting any non-static commands.

mathiasbynens avatar Apr 29 '22 11:04 mathiasbynens

Also likely blocking #121.

mathiasbynens avatar May 03 '22 06:05 mathiasbynens

As the session should be implemented by the embedder, our NodeJS server simply accepts all the session commands: https://github.com/GoogleChromeLabs/chromium-bidi/blob/ca2e4ba66e94b5250f86c544ecfe3e5911aab6f4/src/bidiServerRunner.ts#L48

sadym-chromium avatar May 12 '22 13:05 sadym-chromium

We need this for Puppeteer. Firefox impl supports it and it's part of the spec.

OrKoN avatar Dec 02 '22 11:12 OrKoN

The best the mapper can do is to send a error "500 | session not created", as the session is already exists at the point mapper is created. And the transport implementation (bidiServerRunner) should implement the proper request handling.

sadym-chromium avatar Dec 14 '22 10:12 sadym-chromium

Closing, as session handling cannot be handled by the Mapper.

sadym-chromium avatar Feb 21 '23 15:02 sadym-chromium

Re-opening this based on the latest understanding that mapper should support multiple sessions and that it should provide handling for capabilities implementable via CDP such as ignoreHTTPSErrors. This capability requires calling Security.setIgnoreCertificateErrors on every target as there is no other way to implement it in Chrome.

OrKoN avatar Sep 26 '23 15:09 OrKoN

This has been implemented now.

OrKoN avatar Aug 08 '24 14:08 OrKoN