chromeos_smart_card_connector icon indicating copy to clipboard operation
chromeos_smart_card_connector copied to clipboard

Refactor message awaiting

Open emaxx-google opened this issue 1 year ago • 4 comments

Create a small library function for for waiting on a specific incoming message. Cover it with unit tests.

This code will be reused for implementing the communication with popup dialogs in the manifest v3 mode.

emaxx-google avatar May 15 '24 23:05 emaxx-google

Continuous Integration: All tests passed. C/C++ test coverage: 73.52% lines.

github-actions[bot] avatar May 15 '24 23:05 github-actions[bot]

Continuous Integration: All tests passed. C/C++ test coverage: 73.58% lines.

github-actions[bot] avatar May 16 '24 10:05 github-actions[bot]

I realized I need to add await when calling assertRejects in tests, so that we don't leave the test body before the assertion has been checked.

emaxx-google avatar May 16 '24 15:05 emaxx-google

Continuous Integration: All tests passed. C/C++ test coverage: 73.52% lines.

github-actions[bot] avatar May 16 '24 15:05 github-actions[bot]

Continuous Integration: All tests passed. C/C++ test coverage: 73.58% lines.

github-actions[bot] avatar May 28 '24 18:05 github-actions[bot]