ProjectVisBug icon indicating copy to clipboard operation
ProjectVisBug copied to clipboard

Same domain iframe support

Open argyleink opened this issue 6 years ago • 10 comments

issue is similar to #186

argyleink avatar Dec 18 '18 01:12 argyleink

closing this, i dont think visbug could or should have visibility into actions taken on another domain in an iframe. users of visbug can open those iframes into their own tabs and work from there.

open to ideas though!

argyleink avatar Dec 19 '18 05:12 argyleink

Would like to have the support for iframes.

BreuerChristian avatar Apr 02 '19 12:04 BreuerChristian

can you tell me more about your use case? did you try opening them into new tabs and debugging them there?

argyleink avatar Apr 02 '19 14:04 argyleink

Yeah of course, the product is using a microservice architecture. Thats why the software uses a navigation system outside of the microservices. And the easiest way to bring two or more microservices together is via link or iframe. Its a business software.

BreuerChristian avatar Apr 02 '19 15:04 BreuerChristian

hm, yes, meaningful use case! thanks for sharing it in this thread 👍 i'll keep thinking about how to support iframes, perhaps we'll reopen this when we have a solid plan on how to do it?

argyleink avatar Apr 02 '19 16:04 argyleink

Thanks

BreuerChristian avatar Apr 05 '19 07:04 BreuerChristian

Hey, I have a use case that could really benefit from iframe support. Not supporting iframes from other domains makes sense, but I am curious if same-domain iframes could be supported.

The use case is storybook. storybook renders each story in an iframe. Our team is looking to improve the review process for our designers, and VizBug seems to be an ideal tool for this, but opening each story in a new window is a friction point. Totally understand if this is out of scope, but figured I'd leave a comment just in case.

hayes avatar Jul 14 '21 02:07 hayes

Hey, I have a use case that could really benefit from iframe support. Not supporting iframes from other domains makes sense, but I am curious if same-domain iframes could be supported.

I appreciate the friendly ping 🙂
same domain iframes could be possible yeah! it looks like (i've only looked at a few events) some of the essentials should work. I'm going to reopen this, a prototype could get made to see how it works and how much effort it'll be to get all the tools working inside of there. I imagine there's some critical changes that need made to not assume it's all on the window document, but we'll see 🤓

argyleink avatar Jul 20 '21 22:07 argyleink