workbox
workbox copied to clipboard
fix(workbox-build): make source map filename consistent with injected source file
Fixes #3233 per comments on #2239
- Name the output source map simply
swDestwith.mapappended - Replace the
sourceMappingURLcomment with the new filename - Adjust tests to use different filenames for input and output
- Add simple test to check URL replacement
@jeffposnick would it be possible to get your review here? I just don't want to build a pipeline using this patch if you feel it's a no go.
CC: @tropicadri and @petele for guidance.
At this point I'm wondering if workbox is even being maintained anymore? It hasn't been touched in 6 months even for just responding to issues and dependency bumps.
@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.
@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.
At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!
At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!
I know they passed locally when I first created the PR but I'll take a quick look.
The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.
The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.
Thanks for checking! @tropicadri, over to you for a final look. I LGTM.
@tropicadri are you able to review and release this change? I'd like to avoid creating a patch if I can.