workbox icon indicating copy to clipboard operation
workbox copied to clipboard

fix(workbox-build): make source map filename consistent with injected source file

Open steverep opened this issue 2 years ago • 9 comments

Fixes #3233 per comments on #2239

  • Name the output source map simply swDest with .map appended
  • Replace the sourceMappingURL comment with the new filename
  • Adjust tests to use different filenames for input and output
  • Add simple test to check URL replacement

steverep avatar Jul 28 '23 22:07 steverep

@jeffposnick would it be possible to get your review here? I just don't want to build a pipeline using this patch if you feel it's a no go.

steverep avatar Sep 11 '23 18:09 steverep

CC: @tropicadri and @petele for guidance.

jeffposnick avatar Sep 11 '23 18:09 jeffposnick

At this point I'm wondering if workbox is even being maintained anymore? It hasn't been touched in 6 months even for just responding to issues and dependency bumps.

steverep avatar Nov 24 '23 19:11 steverep

@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.

steverep avatar Jun 06 '24 01:06 steverep

@tomayac any chance this could get looked at soon? It's not exactly a very taxing review.

At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!

tomayac avatar Jun 06 '24 11:06 tomayac

At first sight this LGTM, but the tests fail. Could you look if it's related to this change? Thanks!

I know they passed locally when I first created the PR but I'll take a quick look.

steverep avatar Jun 06 '24 12:06 steverep

The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.

steverep avatar Jun 06 '24 12:06 steverep

The same 8 tests fail on the v7 branch, so they have nothing to do with these changes.

Thanks for checking! @tropicadri, over to you for a final look. I LGTM.

tomayac avatar Jun 06 '24 12:06 tomayac

@tropicadri are you able to review and release this change? I'd like to avoid creating a patch if I can.

steverep avatar Jun 19 '24 18:06 steverep