webstatus.dev icon indicating copy to clipboard operation
webstatus.dev copied to clipboard

Clicking or selecting breadcrumb for feature does nothing

Open dlaliberte opened this issue 1 year ago • 3 comments

After navigating to the feature detail page for any feature, clicking on the name of the feature in the breadcrumb or tabbing the focus to the breadcrumb and hitting the "enter" key does not refresh the page with the URL, although the URL does change. You can see the URL change if you first make a change to either the start or end date, which results in the URL being changed to include the date range.

Clicking the "Feature overview" breadcrumb does redraw the page to show the feature overview.

image

dlaliberte avatar May 14 '24 19:05 dlaliberte

Expected:

  1. Go to a feature detail page for any feature: https://webstatus.dev/features/popover
  2. The chart should load with the default 1 year window of data
  3. Change the date to a non default 1 year window of time.
  4. The chart should re-adjust to the new window
  5. Click the breadcrumb link
  6. The URL clears
  7. The data is reloaded with the default year

What actually happens:

  1. Go to a feature detail page for any feature: https://webstatus.dev/features/popover
  2. The chart should load with the default 1 year window of data
  3. Change the date to a non default 1 year window of time.
  4. The chart should re-adjust to the new window
  5. Click the breadcrumb link
  6. The URL clears
  7. The same window of data from step 3 is shown.

jcscottiii avatar May 23 '24 17:05 jcscottiii

https://github.com/GoogleChrome/webstatus.dev/blob/61aac12b42c8ff64069a1b9eabd794dd13253bed/frontend/src/static/js/components/webstatus-feature-page.ts#L533-L547

jcscottiii avatar May 23 '24 17:05 jcscottiii

This behavior is almost certainly related to the Vaadin router, which intervenes by handling clicks on any anchor tag.

dlaliberte avatar May 23 '24 17:05 dlaliberte

Fixed by #319

jcscottiii avatar May 28 '24 23:05 jcscottiii