web.dev
web.dev copied to clipboard
Learn a11y setup
Adds basic course setup.
Fixes #8143 Fixes #8144 - Copyedited content added Fixes #8146 - Copyedited content added Fixes #8150 - Copyedited content added Fixes #8151 Fixes #8152 Fixes #8502
TODO: Add copyedited copy for above fixes.
Deploy Preview for web-dev-staging ready!
Name | Link |
---|---|
Latest commit | 579747e9d0f9f2cdd5934c4e526116f9f27a7356 |
Latest deploy log | https://app.netlify.com/sites/web-dev-staging/deploys/633715b2bdfd7f0009db81c9 |
Deploy Preview | https://deploy-preview-8702--web-dev-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.
Requested changes
If there are any common problems with the content files you created or modified, they will be listed here.
src/site/content/en/learn/accessibility/aria-html/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/assitive-technology/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/automated-test/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/color-contrast/index.md
- Please add a single newline character to the end of the file. Some programs have trouble with files that don't end with a newline. Affected lines: 334
src/site/content/en/learn/accessibility/complex-topics/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/design-test/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/forms/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/images/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/javascript/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/manual-test/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/measure/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/more-html/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/motion/index.md
- Please change your usage of the following words:
- Do not use
ADHD
. Affected lines: 27
- Do not use
src/site/content/en/learn/accessibility/patterns/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/structure/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/typography/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/user-test/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/video-audio/index.md
- This file passed all of our automated Markdown audits.
src/site/content/en/learn/accessibility/why/index.md
- This file passed all of our automated Markdown audits.
@rachelandrew I'm not sure I understand why Percy is failing. Could you take a look?
I believe I should have all of the components for this course here, based on the Learn HTML course PR.
@heyawhite ignore Percy, but you have lint and presubmit issues. Looks like presubmit (and therefore the preview) are failing due to some bad indentation in YAML.
I fixed the description but you now have an error in an image shortcode.
If you can't spot it I'll pull down the PR tomorrow and debug it.
@heyawhite now building :) your image needed a height and there were a bunch of issues in the assessment yaml, they are really fiddly to do. If you look at my commit you can see what I did, mostly changing quotes.
@argyleink I know you care as much about accessibility as I do.
The content should be ready to go (I have to do a run through to make sure I caught all of the copyeditors copy). But, (as mentioned in our brief chat this morning) I'd love to chat more about your a11y expertise and feedback on future articles.
@rachelandrew Could you give an LGTM before I merge? Thank you!
LGTM