web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

Add Korean Translations for Mini-Apps

Open anaclumos opened this issue 3 years ago • 7 comments

These are translations for Mini-App Posts in Korean. Done.

anaclumos avatar Aug 07 '22 14:08 anaclumos

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 07 '22 14:08 google-cla[bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/ko/mini-apps/mini-app-about/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-alternative-runtime-environments/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-components/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-conclusion/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-devtools/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-example-project/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-markup-styling-and-scripting/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-open-source-projects/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-programming-way/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-project-structure-lifecycle-and-bundling/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-standardization/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-super-apps/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/ko/mini-apps/mini-app-what-are-h5-and-quickapp/index.md

  • This file passed all of our automated Markdown audits.

The translation is now complete—Ready for review.

anaclumos avatar Aug 15 '22 08:08 anaclumos

Hey @matthiasrohmer, I see that you added the label, but this issue hasn't been active for a while. What is the review process like? Is there anything else that I should do?

anaclumos avatar Aug 20 '22 02:08 anaclumos

@rachelandrew Sorry for the ping; I saw you were one of the maintainers here. Anything else I should do? This PR has been idle for a while.

anaclumos avatar Aug 26 '22 23:08 anaclumos

@matthiasrohmer @philipwalton @tomayac Sorry for the ping! Is there anything else needed?

anaclumos avatar Sep 14 '22 22:09 anaclumos

Wow, this is incredible, and as the author of the article series I am humbled and grateful for this contribution! Wholehearted thank you! <3

I don’t speak Korean and am not in the position to review this. @matthiasrohmer & @rachelandrew, what’s the process here? Thanks!

tomayac avatar Sep 14 '22 23:09 tomayac

@tomayac @matthiasrohmer @rachelandrew Is there anything else to be done? What's the process here?

anaclumos avatar Oct 10 '22 04:10 anaclumos

I have pinged some folks. Before we can proceed, you'd need to sign the CLA, please see https://github.com/GoogleChrome/web.dev/pull/8471#issuecomment-1207416574.

tomayac avatar Oct 10 '22 07:10 tomayac

I already signed the CLA in August. Thanks for the reminder!

image

anaclumos avatar Oct 10 '22 17:10 anaclumos

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

stale[bot] avatar Mar 18 '23 08:03 stale[bot]

😉 Still waiting for someone

anaclumos avatar Mar 18 '23 08:03 anaclumos

@rachelandrew The mini apps collection has been stable for a long time now, and therefore the proposed Korean translation runs little risk of getting outdated. I have spot-checked the translations with Google Translate and it all looks good. Are we ready to merge this PR?

tomayac avatar Mar 20 '23 14:03 tomayac

@tomayac apologies, I missed this earlier. Looks like there is a conflict in one file?

Ideally we would have content reviewed by a speaker of the language, otherwise what tends to happen is we get a lot of drive-by edits, which again we don't have anyone to review. However if we can fix the conflicts let's get this merged for now.

rachelandrew avatar Apr 11 '23 08:04 rachelandrew

@tomayac apologies, I missed this earlier. Looks like there is a conflict in one file?

Ideally we would have content reviewed by a speaker of the language, otherwise what tends to happen is we get a lot of drive-by edits, which again we don't have anyone to review. However if we can fix the conflicts let's get this merged for now.

@rachelandrew, Fixed the merge conflict!

anaclumos avatar Apr 11 '23 09:04 anaclumos

Very thrilled to contribute 😄 Gonna screenshot this moment!

anaclumos avatar Apr 11 '23 09:04 anaclumos

Thank you so much for your contribution, @anaclumos, and thanks for your patience until we could land this! <3

tomayac avatar Apr 11 '23 09:04 tomayac

@anaclumos FYI: https://github.com/GoogleChrome/web.dev/pull/9877 may be of interest to you.

tomayac avatar Apr 11 '23 12:04 tomayac