Add Korean Translations for Mini-Apps
These are translations for Mini-App Posts in Korean. Done.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.
Requested changes
If there are any common problems with the content files you created or modified, they will be listed here.
src/site/content/ko/mini-apps/mini-app-about/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-alternative-runtime-environments/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-components/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-conclusion/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-devtools/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-example-project/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-markup-styling-and-scripting/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-open-source-projects/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-programming-way/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-project-structure-lifecycle-and-bundling/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-standardization/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-super-apps/index.md
- This file passed all of our automated Markdown audits.
src/site/content/ko/mini-apps/mini-app-what-are-h5-and-quickapp/index.md
- This file passed all of our automated Markdown audits.
The translation is now complete—Ready for review.
Hey @matthiasrohmer, I see that you added the label, but this issue hasn't been active for a while. What is the review process like? Is there anything else that I should do?
@rachelandrew Sorry for the ping; I saw you were one of the maintainers here. Anything else I should do? This PR has been idle for a while.
@matthiasrohmer @philipwalton @tomayac Sorry for the ping! Is there anything else needed?
Wow, this is incredible, and as the author of the article series I am humbled and grateful for this contribution! Wholehearted thank you! <3
I don’t speak Korean and am not in the position to review this. @matthiasrohmer & @rachelandrew, what’s the process here? Thanks!
@tomayac @matthiasrohmer @rachelandrew Is there anything else to be done? What's the process here?
I have pinged some folks. Before we can proceed, you'd need to sign the CLA, please see https://github.com/GoogleChrome/web.dev/pull/8471#issuecomment-1207416574.
I already signed the CLA in August. Thanks for the reminder!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.
😉 Still waiting for someone
@rachelandrew The mini apps collection has been stable for a long time now, and therefore the proposed Korean translation runs little risk of getting outdated. I have spot-checked the translations with Google Translate and it all looks good. Are we ready to merge this PR?
@tomayac apologies, I missed this earlier. Looks like there is a conflict in one file?
Ideally we would have content reviewed by a speaker of the language, otherwise what tends to happen is we get a lot of drive-by edits, which again we don't have anyone to review. However if we can fix the conflicts let's get this merged for now.
@tomayac apologies, I missed this earlier. Looks like there is a conflict in one file?
Ideally we would have content reviewed by a speaker of the language, otherwise what tends to happen is we get a lot of drive-by edits, which again we don't have anyone to review. However if we can fix the conflicts let's get this merged for now.
@rachelandrew, Fixed the merge conflict!
Very thrilled to contribute 😄 Gonna screenshot this moment!
Thank you so much for your contribution, @anaclumos, and thanks for your patience until we could land this! <3
@anaclumos FYI: https://github.com/GoogleChrome/web.dev/pull/9877 may be of interest to you.