web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

Strip double quotes from heading slugs

Open tunetheweb opened this issue 2 years ago • 2 comments

Fixes #8259

Changes proposed in this pull request:

  • Automatically strip double quotes from slugs to avoid JavaScript console error and create nicer URLs.

Seems a safe enough change but not totally familiar with the site to know if there are any other impacts? I searched through the articles for any references and updated the few there are.

When you're ready to submit your PR, don't forget to add the $-presubmit label.

tunetheweb avatar Jul 01 '22 13:07 tunetheweb

Deploy Preview for web-dev-staging ready!

Name Link
Latest commit 84d4cc97a5ef2dcd290344d152815f6e11732d2d
Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/62fa73a51c754900089a5da9
Deploy Preview https://deploy-preview-8263--web-dev-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 01 '22 13:07 netlify[bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/movikantirevo/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/en/blog/understanding-css/index.md

  • This file passed all of our automated Markdown audits.

src/site/content/en/blog/vitals-spa-faq/index.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 309, 327

src/site/content/en/blog/webrtc-basics/index.md

  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 55
  • Please change your usage of the following words:
    • Do not use master. Affected lines: 601

src/site/content/en/fast/serve-images-with-correct-dimensions/index.md

  • This file passed all of our automated Markdown audits.