Fix code example

[polotek]

Changes proposed in this pull request:

Minor content fix for correctness. The previous code example ran someFunction immediately instead of inside the promise callback.

When you're ready to submit your PR, don't forget to add the $-presubmit label.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

[alexandrascript]

Adding @housseindjirdeh who wrote the article and @malchata for performance expertise -- if one of you confirms, I'll merge

[malchata]

Thanks for catching this @polotek! All looks good to me. Only thing is we'll need you to sign the CLA before the workflow will allow us to merge your contribution.

[chrome-devrel-review-bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/fast/reduce-javascript-payloads-with-code-splitting/index.md

• This file passed all of our automated Markdown audits.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

[miguelfdezc]

Hi @polotek! Are you still working on this fix?

If not, I'm willing to take over and create an issue and PR to fix the code so we can improve the documentation

@heyawhite @housseindjirdeh @malchata waiting for your response to make my contribution

[malchata]

@miguelfdezc did you sign the CLA? If not, please do so we can merge this.

[miguelfdezc]

Hi @malchata, I did sign the CLA. I believe you wanted to tag @polotek instead? Actually, the reason why I commented was that I wanted to fix this too but I was there was this PR already but it was stale because of the missing CLA sign

[malchata]

@polotek, if you can sign the CLA, I can merge this change. Sorry for the hassle!

[matthiasrohmer]

@miguelfdezc, feel free to go ahead and open another PR with the fix while mentioning this one 🙂

[matthiasrohmer]

Superseded by #8589.

[polotek]

Thank you for trying to get in touch to give me full attribution. I have now signed the CLA for future reference. But I'm fine with how this ticket was resolved.