web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

Turn browsercompat into table

Open devnook opened this issue 3 years ago • 3 comments

Fixes #7310

devnook avatar Feb 07 '22 16:02 devnook

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 6c8c0341d774dbc85ce69f52cf1e6e1e35e3e0a1

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/62014512ec072c0007e28f89

😎 Browse the preview: https://deploy-preview-7313--web-dev-staging.netlify.app

netlify[bot] avatar Feb 07 '22 16:02 netlify[bot]

@devnook I'm wondering if we should make the label "Browser Compat" into a <caption>? What would be the best for a11y?

rachelandrew avatar Feb 08 '22 08:02 rachelandrew

FWIW, this is what the <table> implementation looks like in Feedly, when I access the RSS feed for the staging server:

Screen Shot 2022-03-10 at 9 28 18 AM

I guess that's better? I'm okay with this PR, but I don't know the answer to Rachel's question about <caption> best practices.

(Not to derail the PR, but another approach would be to turn the original <span>s into <li>s, with a parent <ul>. This info strikes me as being "list-like" and the unstyled <ul>/<li> combo might end up being the most legible in an RSS reader.

jeffposnick avatar Mar 10 '22 14:03 jeffposnick

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

stale[bot] avatar Nov 23 '22 01:11 stale[bot]

Fixed by https://github.com/GoogleChrome/webdev-infra/pull/60.

matthiasrohmer avatar Mar 14 '23 13:03 matthiasrohmer