web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

Published 20 hours ago • verified publisher icon GoogleChrome

feat(select): create `web-select` element, fixes #7176

Open MichaelSolati opened this issue 3 years ago • 6 comments

Fixes #7176

Changes proposed in this pull request:

  • create web-select component

When you're ready to submit your PR, don't forget to add the $-presubmit label.

MichaelSolati avatar Jan 14 '22 23:01 MichaelSolati

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/component-library/select/select.md

  • This file passed all of our automated Markdown audits.

chrome-devrel-review-bot avatar Jan 14 '22 23:01 chrome-devrel-review-bot

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: f5719acbd3ccda163d523be16401333334e19ccb

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/61f2c9d307303d0007793134

😎 Browse the preview: https://deploy-preview-7177--web-dev-staging.netlify.app

netlify[bot] avatar Jan 14 '22 23:01 netlify[bot]

@philipwalton Can you please take another look?

devnook avatar Feb 01 '22 10:02 devnook

@philipwalton here the element on a page you can tinker with https://deploy-preview-7177--web-dev-staging.netlify.app/design-system/preview/select/web-select/

MichaelSolati avatar Feb 01 '22 14:02 MichaelSolati

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. To prevent this from happening, leave a comment.

stale[bot] avatar Jun 11 '22 03:06 stale[bot]

@philipwalton, the accessibility issues you mentioned seem to be fixed for desktop. Can you take another look?

Also some context on this would be helpful. Is this created to have a select that fits web.dev's style? Because that comes with the price of decreased accessibility on Android and iOS devices as they don't open the native select drawer anymore.

matthiasrohmer avatar Aug 17 '22 09:08 matthiasrohmer

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

stale[bot] avatar Nov 23 '22 01:11 stale[bot]

@devnook would have more context on whether or not this is still needed.

philipwalton avatar Nov 23 '22 17:11 philipwalton