web-vitals icon indicating copy to clipboard operation
web-vitals copied to clipboard

Cap TTFB in attribution

Open tunetheweb opened this issue 1 year ago • 2 comments

Fixes #439

tunetheweb avatar Mar 05 '24 17:03 tunetheweb

...thinking about this abit more (and having my memory jogged after looking at the bugs in the source code comments), I think it might be better to not report attribution data in cases where the TTFB value is not trustworthy (since an incorrect TTFB value would impact the accuracy of other sub-part timing values as well).

We don't report the TTFB metric in these cases, and I think it would make sense to do that here as well.

philipwalton avatar Mar 10 '24 23:03 philipwalton

OK re-did this to load from single lib function and also return without an attribution model when the TTFB is invalid.

tunetheweb avatar Mar 11 '24 14:03 tunetheweb