samples icon indicating copy to clipboard operation
samples copied to clipboard

Adds `controls` attribute to final controlsList media sample

Open bgradin opened this issue 6 years ago • 4 comments

The final sample on the controlsList samples page is missing the controls attribute, so you can't see the controls.

bgradin avatar Nov 20 '18 17:11 bgradin

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Nov 20 '18 17:11 googlebot

I signed it!

bgradin avatar Nov 20 '18 17:11 bgradin

CLAs look good, thanks!

googlebot avatar Nov 20 '18 17:11 googlebot

The last one is specifically about not showing controls. The previous one has controls though.

image

beaufortfrancois avatar Nov 21 '18 07:11 beaufortfrancois