rendertron icon indicating copy to clipboard operation
rendertron copied to clipboard

[FEATURE] Allow support for waitUntil configuration

Open fabiangarga opened this issue 3 years ago • 3 comments

I implemented this PR to resolve #754 . Added the waitUntil option for the rendertron configuration.

How to use the configuration update:

(config.json)

{
    ...
    "waitUntil": [
        "domcontentloaded",
        "networkidle2"
    ]
}

fabiangarga avatar Jul 26 '21 23:07 fabiangarga

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 26 '21 23:07 google-cla[bot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

fabiangarga avatar Jul 27 '21 14:07 fabiangarga

@googlebot I signed it!

fabiangarga avatar Dec 07 '21 15:12 fabiangarga