lighthouse
lighthouse copied to clipboard
GoogleChrome
Display plugins in footer of report
Currently, at the footer of the report the LH version and GH issue link is included. I propose that we also include any used the plugins and respective issue links.
Hey @jburger424, I'm interested in helping you out. Any hint where I can start?
We recently added "Axe Version" to the runtime settings. #10729
@jburger424 do you think we should also put plugin version numbers here?
I propose that we also include any used the plugins and respective issue links.
Would linking to the npm page be sufficient? It'd be straightforward (https://www.npmjs.com/package/PACKAGE_NAME). Linking to the issues page would require adding that data in the Plugin config.
Suggestion:
An additional row in Runtime Settings table for each plugin. Plugin name links to npm (also also make Axe a link). Each plugin&version gets added to the new lhr.environment.credits). The hard part here is how to get the plugin version. Any ideas? would require("../../../node_modules/PACKAGE_NAME/package.json").version work in all our envs (+ some changes to bundler)?
Yeah that seems like a good fit to me!
Linking to the package SGTM, can make sure to visibly link to issues in the readme.
Single row per plugin seems great to me. I think that the require method should work fine, but would need to verify.
I have an interest in working on this. Could you assign it to me? What are the files or folders I am working with?
Hi, I'd like to work on this issue. Could you clarify the plugins you want displayed? It's unclear to me from the current comment thread.
Hey ! Iam interested to work with this issue . Is this still active?
@connorjclark is there still any interest in updating the footer of reports? I see it has changed a bit since this comment.
@tannerdolby I think there's still some utility to this.
The best place for it now would be as part of the hover tooltip on the bottom-left item in the footer:
That is found here: https://github.com/GoogleChrome/lighthouse/blob/53e0a595af7512b9769debc973006dd3e45fb400/report/renderer/report-renderer.js#L157-L159
To people asking "may I work on this": the answer is always yes. We don't like to assign specific people, because sometimes people will volunteer for something then have something come up and the issue remains but "assigned". So please just comment here to "stake a claim" and send a PR. Thanks!