lighthouse-stack-packs icon indicating copy to clipboard operation
lighthouse-stack-packs copied to clipboard

General Discussion

Open housseindjirdeh opened this issue 6 years ago • 10 comments

Opening this issue to have a place where people can leave general suggestions 💬.

Some preliminary thoughts to kick things off:

  • Which platforms should we support?
    • After WordPress, we can continue to target other CMS platforms (like Drupal) as well as explore how to include suggestions for JavaScript frameworks (Angular, React, etc...). Anything else?
  • Should we show a toggle to switch between the original Lighthouse report and an updated one with platform-specific strings included? Or should we always surface platform-specific audit messages if a tool is detected on the webpage?

Note: For details on how platform packs will be integrated into core, take a look at the RFC.

housseindjirdeh avatar Jan 16 '19 18:01 housseindjirdeh

Not a platform/framework per se but would love to see more detailed report about images (or even media) in general.

tpiros avatar Feb 01 '19 08:02 tpiros

This looks like you are just adding secondary messages based on the platform right now. Not really adding tests at the moment. Are you planning on adding additional tests/rules for a CMS? Plus how do you plan on actually auditing server-side code in a platform like WordPress?

Since I use my own platform, can I use this as a model to create my own customized report or an I better off just running it using a node module and then rendering the JSON against my own template. Seems like the same thing you are going right now.

docluv avatar Feb 02 '19 20:02 docluv

I think the opensource CMS TYPO3 might be an interesting next platform. It is already the cms with the highest density of fast FCP as you can see on https://discuss.httparchive.org/t/cms-performance/1468. Besides that the CMS and the community is really having performance as one of the most important topics. So I will definitely go for TYPO3 as one of the next platforms!

haassie avatar Feb 03 '19 06:02 haassie

@docluv Yep, that is correct. We're only planning to add secondary messages for already existing audits to make them more platform-specific. We're not planning to add any extra audits for any tool.

We don't plan to do anything fancy to audit server-side code. We're planning to rely on audits that are already available and flag common issues that folks who use WordPress are most likely experiencing.

If you wanted to set up a report of your own for a specific tool, you might just have to dive into the audit files and include additional messages yourself. You can then boot up the report with Lighthouse Viewer like I did with the first prototype. Once the feature is fully developed however, we may have a better way to fork and build your own version.

housseindjirdeh avatar Feb 05 '19 01:02 housseindjirdeh

@haassie I created a separate issue (#7) to list down different tools we can work towards supporting :)

housseindjirdeh avatar Feb 05 '19 01:02 housseindjirdeh

Nice work! Would love to see this for Magento after Wordpress. We're doing some great things around PWA as a commerce platform with our community. /cc @zetlen

ericerway avatar Feb 05 '19 22:02 ericerway

Not framework specific but would love to see more details and reporting for WebGL specific stuff; three.js could also be a framework to focus on.

ezekielchentnik avatar Feb 06 '19 18:02 ezekielchentnik

@ericerway We've already been chatting about supporting Magento :) We'll most definitely keep you in the loop when we begin rolling things out for more than just WordPress.

CC @rowan-m

housseindjirdeh avatar Feb 07 '19 00:02 housseindjirdeh

OK ... trying to install for the first time and making what I can only assume is some stupid issue.

I keep getting a missing manifest file error.

Hoping someone can help me remedy this PEBKAC scenario.

Thanks !

onlineinference avatar Mar 16 '20 21:03 onlineinference

Hi @beanstalkim! Are you just trying to install the library itself as an npm dependency?

housseindjirdeh avatar Mar 17 '20 15:03 housseindjirdeh