lighthouse-ci icon indicating copy to clipboard operation
lighthouse-ci copied to clipboard

Update lighthouse and express versions to get rid of vulnerable cookie dependency

Open BeniRupp opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. The current @lhci/cli version depends on a vulnerable version of cookies:

   └─ @lhci/cli@npm:0.14.0 (via npm:^0.14.0)
      ├─ @lhci/utils@npm:0.14.0 (via npm:0.14.0)
      │  └─ lighthouse@npm:12.1.0 (via npm:12.1.0)
      │     └─ @sentry/node@npm:6.19.7 (via npm:^6.17.4)
      │        └─ cookie@npm:0.4.2 (via npm:^0.4.1)
      ├─ express@npm:4.21.1 (via npm:^4.17.1)
      │  └─ cookie@npm:0.7.1 (via npm:0.7.1)
      └─ lighthouse@npm:12.1.0 (via npm:12.1.0)

Describe the solution you'd like We have to upgrade

Describe alternatives you've considered

Additional context

BeniRupp avatar Dec 03 '24 07:12 BeniRupp

Related: https://github.com/GoogleChrome/lighthouse-ci/issues/1058

sdavids avatar Dec 06 '24 11:12 sdavids

express should be updated to >=4.21.2; the cookie issue has been resolved in 4.21.1

sdavids avatar Dec 16 '24 12:12 sdavids

The low vulnerability in cookie by npm audit is still an outstanding issue: https://github.com/advisories/GHSA-pxg6-pf52-xh8x Image

Updating lighthouse in @lhci/cli from 12.1.0 to 12.3.0 should update the dependency tree and address the CVE.

ejclark avatar Feb 13 '25 15:02 ejclark