devtools-docs icon indicating copy to clipboard operation
devtools-docs copied to clipboard

Remove heap-profiling and forward to javascript-memory-profiling?

Open Garbee opened this issue 10 years ago • 6 comments

I noticed when fixing another issue that the heap-profiling page is very outdated and the javascript-memory-profiling page covers the same stuff but in more detail and updated. Is it safe to remove & forward?

Garbee avatar Feb 10 '15 12:02 Garbee

yup we can kill.

the -summary page is still heavily linked though.

paulirish avatar Feb 16 '15 19:02 paulirish

Linked internally or from external sources?

If external then a redirect will be in place which should make that a non-issue. If internal then I'll be patching those with my PR for the removal and redirect, so no problem there.

Garbee avatar Feb 16 '15 19:02 Garbee

-summary page is linked internally. it's actually a demo.

the heap-profiling page i dont see linked, but we should have a redirect on it, yeah

paulirish avatar Feb 16 '15 21:02 paulirish

If a demo is in there then it should be refactored into its own page like the others. On Feb 16, 2015 4:43 PM, "Paul Irish" [email protected] wrote:

-summary page is linked internally. it's actually a demo.

the heap-profiling page i dont see linked, but we should have a redirect on it, yeah

— Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/devtools-docs/issues/240#issuecomment-74576971 .

Garbee avatar Feb 16 '15 22:02 Garbee

oh wait, you mean heap-profiling-summary. not heap-profiling as summary.

I'll look into the best way to handle that if it needs to be touched. I was more focusing just on heap-profiling.html itself.

Garbee avatar Feb 16 '15 23:02 Garbee

oh wait, you mean heap-profiling-summary. not heap-profiling as summary.

correct.

and heap-profiling.html is dead, yeah.

paulirish avatar Feb 17 '15 18:02 paulirish