Encouraging feedback - github link in the footer

[kdzwinel]

We agreed to add a link to https://github.com/GoogleChrome/devtools-docs/issues in the footer of the docs. However, I don't see any template in this repo that controls contents of the footer. Any ideas?

Also, I just spotted that there is a 'Send Feedback' button in the bottom right corner. Does anyone know where these suggestions go?

[paulirish]

@Garbee knows the templating system the best these days.

@heatheramahan do you know about the feedback button?

[ghost]

@Meggin might know?

[jaredwilli]

I think @dr4b may have an idea, possibly...

[paulirish]

@dr4b we have a google feedback widget on DCC. know where we can review the reports?

[kdzwinel]

Note to self - footer found: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/extensions/docs/templates/private/cc.html

[kdzwinel]

The solution looks like this (I briefly discussed it with @Garbee ): Patch sent to Paul.

[paulirish]

CL is up: https://codereview.chromium.org/831263004

[Meggin]

Cool. The solution isn't perfect, but it's better than what's there, so I will approve it.

We really should have the 'send feedback' button kick-off a crbug at the very least. And eventually, when you go to raise a bug in a particular area, it kicks off the correct issue tracker for that area.

Meggin

On Mon, Jan 5, 2015 at 1:40 PM, Paul Irish [email protected] wrote:

CL is up: https://codereview.chromium.org/831263004

— Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/devtools-docs/issues/201#issuecomment-68786736 .

[Meggin]

Actually, I'm not a reviewer-- Paul B is. Paul-- can you add me as a reviewer too? Once Paul is happy with the change, I can give the lgtm and you can commit.

Any chance we can see a staged version to check the styles?

Meggin

On Mon, Jan 5, 2015 at 2:04 PM, Meggin Kearney [email protected] wrote:

Cool. The solution isn't perfect, but it's better than what's there, so I will approve it.

We really should have the 'send feedback' button kick-off a crbug at the very least. And eventually, when you go to raise a bug in a particular area, it kicks off the correct issue tracker for that area.

Meggin

On Mon, Jan 5, 2015 at 1:40 PM, Paul Irish [email protected] wrote:

CL is up: https://codereview.chromium.org/831263004

— Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/devtools-docs/issues/201#issuecomment-68786736 .

[paulirish]

technically you can add yourself ;) … but yes added.​

[paulirish]

@kdzwinel https://chrome-apps-doc.appspot.com/_patch/831263004/devtools/index

we can fix it with negative margin for desktop and maybe hide it on mobile? Can you come up with some styles that would work for this?

Thanks

[kdzwinel]

Sure, I'm on it. BTW it looks much cleaner on the very bottom than over the CC message :+1:

[kdzwinel]

1. @paulirish Is that what you had in mind?

---

2. BTW it looks like 'send feedback' button is no longer there (at least on production): https://developer.chrome.com/devtools/index Is it coming back? I'm asking because it affects where "Report issues on GitHub" message should be positioned.

---

3. Also, I just spotted that "Report a content bug" link still opens up the feedback popup, but it actually points to crbug.com/new . So maybe that's where all the feedback from ''send feedback'' button went?

[Garbee]

I think the "Report a content bug" link was recently updated. Looking at the internet archive from earlier this year it did open the same feedback popup. And I wouldn't be surprised if they took the floating button out since it is about to be confusing with the new footer.

Although the chromium issue tracker isn't well suited to content bugs in docs... Any way we could just get that link changed to a github repo? Even if it is one more general repo specifically for doc issues across all of DCC to get sent to get forwarded to the right repo.

[paulirish]

• "Send feedback" is not coming back. I submitted a CL for all of DCC to remove it. "report a content bug" handles it: https://codereview.chromium.org/836833002/
• yes "report a content bug" links to crbug but pops open feedback dialog. that's actually kind of OK. we just did this change so we'll see how it goes.

chromium issue tracker is what every other team on DCC uses for issues, except us. It's mostly an experiment to see what happens.

When we put in this devtools-bug link.. Let's add CSS to display:none the "content bug" link. EZ PZ.

[paulirish]

1. @paulirish Is that what you had in mind?

I actually was thinking this link is in the white section above the "global footer"

[kdzwinel]

@paulirish http://imgur.com/a/bhtm9 - version no.1 or no.2?

BTW negative margin causes double-scrollbar (see screenshot no. 3), any ideas why?

[Garbee]

So, the link is now to http://crbug.com/new however the data-feedback attribute exists which overrides the anchor and instead does the old feedback popup that no one outside of Google gets to see.

[Meggin]

How do you access the feedback attribute? I don't see it.

On Mon, Feb 9, 2015 at 3:21 PM, Jonathan Garbee [email protected] wrote:

So, the link is now to http://crbug.com/new however the data-feedback attribute exists which overrides the anchor and instead does the old feedback popup that no one outside of Google gets to see.

— Reply to this email directly or view it on GitHub https://github.com/GoogleChrome/devtools-docs/issues/201#issuecomment-73612763 .

[Garbee]

Seeing that right through my DevTools. site.js contains the code triggering the feedback modal:

function openFeedback(e) {
  e.preventDefault();
  userfeedback.api.startFeedback({productId: 86265});
}

function addGoogleFeedback() {
  [].forEach.call(document.querySelectorAll('[data-feedback]'), function(el, i) {
    el.addEventListener('click', openFeedback);
  });
}