developer.chrome.com icon indicating copy to clipboard operation
developer.chrome.com copied to clipboard

Published 20 hours ago • verified publisher icon GoogleChrome

Adds the new FilterSheet shortcode

Open johnrich85 opened this issue 2 years ago • 1 comments

Changes proposed in this pull request:

Adds a new shortcode: FilterSheet

Design: image

johnrich85 avatar Oct 11 '22 13:10 johnrich85

Deploy Preview for developer-chrome-com ready!

Name Link
Latest commit f43202ba32d3e4d691ede842aff0adea0494f167
Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/6357b2ba27fdc60008cea901
Deploy Preview https://deploy-preview-3980--developer-chrome-com.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 11 '22 14:10 netlify[bot]

We try to keep shortcodes for authoring elements that can be embedded in the article body (so mainly used in .md files). This filters element is intended to be used in layout and is not a reusable component - there's no need to make it a shortcode.

I'd consider putting it directly in the calendar page, or extracting potentially reusable elements into a macro (but not a shortcode).

devnook avatar Oct 24 '22 07:10 devnook

Cheers @devnook. I've made the requested changes

johnrich85 avatar Oct 25 '22 09:10 johnrich85