chromium-dashboard icon indicating copy to clipboard operation
chromium-dashboard copied to clipboard

Store `rollout_milestone` field in the `milestones` field in Stage entities

Open DanielRyanSmith opened this issue 1 year ago • 1 comments

Almost all references to milestone fields are stored in Stage.milestones, which uses the MilestoneSet kind. The exception for this is rollout_milestone for enterprise features, which is a separate field from an older implementation with the milestone field unnecessarily separate from similar milestone references. Migrating this rollout_milestone field to instead live in the milestones field (as milestones.desktop_first), will consolidate this milestone field to be handled the same way all other milestone fields are.

DanielRyanSmith avatar Apr 02 '24 21:04 DanielRyanSmith

Daniel addressed this in PR #3771.

jrobbins avatar Apr 04 '24 14:04 jrobbins

The rollout_milestone field is now being stored in the FeatureEntry.milestones.desktop_first for all features. The next step would be to update references in the code to no longer use rollout_milestone.

DanielRyanSmith avatar Oct 10 '25 17:10 DanielRyanSmith