chromium-dashboard icon indicating copy to clipboard operation
chromium-dashboard copied to clipboard

Missing edit icon on new features page for features I own

Open GabriellaMSanchez opened this issue 1 year ago • 6 comments

Describe the bug On the new features page, the edit icon is missing even though I am signed in and I own this feature. I am able to click into this feature and edit it on the feature detail page. This bug occurs whether I am logged into my personal email or the [email protected] email log in.

To Reproduce Steps to reproduce the behavior:

  1. Be logged into your account or the [email protected] account.
  2. Click on "All Features" on the side bar.
  3. Click on "Try out our new features page".
  4. See error [screenshot below]
Screen Shot 2024-01-03 at 6 43 53 PM

GabriellaMSanchez avatar Jan 04 '24 03:01 GabriellaMSanchez

I have confirmed that the edit icon does not display here for editable features of users without special site permissions. It seems that the permissions are being passed down to the table checking if the user is a site editor or admin that can edit every feature. That means that either the edit icon will display for all features to editor-level users, or not at all for normal users, even if that user has access to edit the feature.

DanielRyanSmith avatar Jan 08 '24 18:01 DanielRyanSmith

Please assign it to me. I want to work on that.

Ali7040 avatar Feb 22 '24 10:02 Ali7040

Hey, This is Balraj, I am new to open source and I want to contribute to this issue. @DanielRyanSmith @GabriellaMSanchez can you please elaborate it to me

BalrajDhakad avatar Feb 23 '24 14:02 BalrajDhakad

Screenshot_2024_0314_144419 I have not seen create feature and edit icon .can you please guide me

Rishikesh63 avatar Mar 14 '24 09:03 Rishikesh63

@DanielRyanSmith I have an idea to fix this. If this issue is still open, I would like to work on it.

r3yc0n1c avatar Mar 22 '24 12:03 r3yc0n1c

I might have fixed this issue in https://github.com/GoogleChrome/chromium-dashboard/pull/3734

afeedhshaji avatar Mar 23 '24 01:03 afeedhshaji