chromium-dashboard icon indicating copy to clipboard operation
chromium-dashboard copied to clipboard

Published 20 hours ago • verified publisher icon GoogleChrome

Toast is briefly displayed on page load

Open jrobbins opened this issue 2 years ago • 4 comments

On several of our pages, the chromedash-toast element briefly appears in the bottom left corner if the page is initially loaded or reloaded (not on a SPA navigation). The fact that the toast flashed by looks like a mistake or error, even though it does not prevent the user from accomplishing any use case. We should prevent it because it is not intended to be initially displayed.

jrobbins avatar Nov 28 '22 21:11 jrobbins

Several pages: roadmap, myfeatures, newfeatures, and probably others.

jrobbins avatar Nov 28 '22 21:11 jrobbins

https://github.com/GoogleChrome/chromium-dashboard/assets/56164590/63db554a-dc29-4089-9871-3562f59a12b6

Here is an example of the behavior you can see on the bottom left on page refresh.

DanielRyanSmith avatar Mar 12 '24 16:03 DanielRyanSmith

Hi, I'd like to work on this.

r3yc0n1c avatar Mar 13 '24 12:03 r3yc0n1c

Hey @r3yc0n1c, feel free to open a PR for this work, and you can pose any questions you have here as well!

DanielRyanSmith avatar Mar 13 '24 16:03 DanielRyanSmith

Sure, there was some setup issues but now I got the dev-env ready, working on it... will drop a PR soon!

r3yc0n1c avatar Mar 18 '24 07:03 r3yc0n1c

@r3yc0n1c Hi I have already made a pull request on this issue and closing it.

impact-maker avatar Mar 18 '24 07:03 impact-maker

@r3yc0n1c Hi I have already made a pull request on this issue and closing it.

Oh, I thought this is open to work, Daniel assigned it to me.

r3yc0n1c avatar Mar 20 '24 15:03 r3yc0n1c