chromium-dashboard icon indicating copy to clipboard operation
chromium-dashboard copied to clipboard

When viewing a non-existent feature, the UI just hangs

Open jrobbins opened this issue 3 years ago • 3 comments

Describe the bug If the user tries to visit a non-existent feature (e.g., a deleted one or a random number for the ID), then the page just shows a shimmering skeleton forever. It should say "404" or "Feature not found".

To Reproduce Steps to reproduce the behavior:

  1. Go to https://cr-status-staging.appspot.com/feature/12345

Additional context There might be something shown in the toast, but the toast is not being displayed due to a different error that I have a pending PR for.

The message that the toast is set to show is "Some errors occurred. Please refresh the page or try again later." But, that is not helpful in the case of a 404.

jrobbins avatar Sep 20 '22 01:09 jrobbins

@kevinshen56714 FYI.

jrobbins avatar Sep 20 '22 01:09 jrobbins

How about making a base class for all our page classes as we discussed here, in which we can have a renderErrorMessage() method that basically defines a custom 404 page? If there's a 404 error from the server from any of the pages, we can display the error message on the page.

kevinshen56714 avatar Sep 20 '22 17:09 kevinshen56714

I want to work on this issue. Pls assign it to me.

aaryan-verma avatar Oct 11 '22 10:10 aaryan-verma