chromium-dashboard icon indicating copy to clipboard operation
chromium-dashboard copied to clipboard

Convert guide/editall page into a component

Open kevinshen56714 opened this issue 2 years ago • 0 comments

This PR converts content in guide/editall.html into the <chromedash-guide-editall-page> component. The changes include:

  1. Created chromedash-guide-editall-page.js and chromedash-guide-editall-page_test.js
  2. Slightly modified the template data of editall.html in guide.py so that the flat_forms can be passed into <chromedash-guide-editall-page> as string and then get JSON.parse() when rendering.
  3. The guide/edit.html is now a single component file
  4. Added loading skeletons for the page, see the snapshot below: Screen Shot 2022-08-15 at 3 57 14 PM

kevinshen56714 avatar Aug 16 '22 00:08 kevinshen56714